Skip to content

Update esp32-hal-misc.c #11830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update esp32-hal-misc.c #11830

wants to merge 1 commit into from

Conversation

arersen
Copy link

@arersen arersen commented Sep 14, 2025

Fix millis() returning nanoseconds instead of milliseconds

Description of Change

Fixed the millis() implementation.
Previously, it incorrectly returned values in nanoseconds due to dividing esp_timer_get_time() (microseconds) by 1000ULL.
Now the function multiplies by 1000ULL, so it properly returns elapsed time in milliseconds.

Test Scenarios

  • Tested on Arduino-esp32 core v3.0.0
  • Hardware: ** LILYGO ESP32**
  • Verified that millis() increments correctly every 1 ms compared to micros().

@arersen
Update esp32-hal-misc.c
567c124 
Fixed the millis() function, which previously returned values in nanoseconds due to dividing esp_timer_get_time() (microseconds) by 1000ULL. The implementation now multiplies by 1000ULL, ensuring the function correctly returns elapsed time in milliseconds.
@arersen arersen requested a review from a team as a code owner September 14, 2025 10:21
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions GitHub Actions
Copy link
Contributor

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Update esp32-hal-misc.c":
    • body's lines must not be longer than 100 characters
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello arersen, we appreciate your contribution to this project!

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.
🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.
Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 567c124

@Jason2866
Copy link
Collaborator

One tick is a micro second, to get the time for one tick in milliseconds it needs to be divided by 1000.
The current implementation is correct.

@arersen arersen closed this Sep 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arersen @CLAassistant @Jason2866